On 28/08/18 04:26, Marek Olšák wrote:
On Fri, Aug 24, 2018 at 10:33 AM, Michel Dänzer <mic...@daenzer.net> wrote:
On 2018-08-24 1:06 p.m., Timothy Arceri wrote:
More and more games seem to require this so lets make it a config
option.
---
  src/gallium/drivers/radeonsi/driinfo_radeonsi.h |  1 +
  src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c   | 10 +++++++---
  src/util/xmlpool/t_options.h                    |  5 +++++
  3 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/src/gallium/drivers/radeonsi/driinfo_radeonsi.h 
b/src/gallium/drivers/radeonsi/driinfo_radeonsi.h
index 7f57b4ea892..8c5078c13f3 100644
--- a/src/gallium/drivers/radeonsi/driinfo_radeonsi.h
+++ b/src/gallium/drivers/radeonsi/driinfo_radeonsi.h
@@ -3,6 +3,7 @@ DRI_CONF_SECTION_PERFORMANCE
      DRI_CONF_RADEONSI_ENABLE_SISCHED("false")
      DRI_CONF_RADEONSI_ASSUME_NO_Z_FIGHTS("false")
      DRI_CONF_RADEONSI_COMMUTATIVE_BLEND_ADD("false")
+    DRI_CONF_RADEONSI_ZERO_ALL_VRAM_ALLOCS("false")
  DRI_CONF_SECTION_END

  [...]

@@ -414,3 +414,8 @@ DRI_CONF_OPT_END
  DRI_CONF_OPT_BEGIN_B(radeonsi_clear_db_cache_before_clear, def) \
          DRI_CONF_DESC(en,"Clear DB cache before fast depth clear") \
  DRI_CONF_OPT_END
+
+#define DRI_CONF_RADEONSI_ZERO_ALL_VRAM_ALLOCS(def) \
+DRI_CONF_OPT_BEGIN_B(radeonsi_zerovram, def) \
+        DRI_CONF_DESC(en,"Zero all vram allocations") \
+DRI_CONF_OPT_END


I'd name the option simply "zerovram", so it could be used by other
drivers as well.


BTW, AFAICT, currently this only affects BOs allocated from the kernel,
not those re-used from the BO cache. I wonder if that couldn't still
cause trouble with some apps.

It could.

Maybe related to this?

https://bugs.freedesktop.org/show_bug.cgi?id=65968#c12

Anyway:

Reviewed-by: Marek Olšák <marek.ol...@amd.com>

Marek



--
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to