On 05/09/2018 10:55, Sergii Romantsov wrote:
Hello, sorry for delay in answer.
I think you might need to update the other build systems
(Android.mk/meson)
Have done it for meson, but with Android i can't check if issue
present or if it will be fixed. And seems it requires some extra
knowledge/time. Could we try to discuss it in separate thread/patch?
Actually, it looks like Android.mk sources its flags from the
Makefile.common.mk so this is probably fine.
The toplevel meson/makefile have a -mstackrealign that seem to
make the description of the issue you're fixing.
Maybe that's where this change should go.
Do you mean to move compilation flag for all libs? Seems at this
moment flag mstackrealign is needed only for i965-dri, so maybe its
better to enable only if needed?
Sounds like Dylan knows better. Adding it to the src/intel level is fine.
For meson it might be nice to add a c_sse2_args = ['-msse2',
'-mstackrealign'] at the src/intel level
Done
Also, since this is extremely trivial and fixes bugs, this should
be cc'd to mesa stable for 18.1 and 18.2
Sorry, not clear for me: should i do anything with that?
Just add following tag, so that people maintaining the stable branches
know what to cherry-pick from master :
CC: <mesa-sta...@lists.freedesktop.org>
On Wed, Sep 5, 2018 at 1:19 AM, Dylan Baker <dy...@pnwbakers.com
<mailto:dy...@pnwbakers.com>> wrote:
Quoting Sergii Romantsov (2018-09-04 03:46:23)
> Seems in case of 32-bit library, usage of msse2 makes
> some stack corruption or incorrect instructions.
> Usage with mstackrealign fixes that case.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107779
<https://bugs.freedesktop.org/show_bug.cgi?id=107779>
> Signed-off-by: Sergii Romantsov
<sergii.romant...@globallogic.com
<mailto:sergii.romant...@globallogic.com>>
> ---
> src/mesa/drivers/dri/i965/Makefile.am | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/Makefile.am
b/src/mesa/drivers/dri/i965/Makefile.am
> index 889d4c6..0afa7a2 100644
> --- a/src/mesa/drivers/dri/i965/Makefile.am
> +++ b/src/mesa/drivers/dri/i965/Makefile.am
> @@ -44,7 +44,7 @@ AM_CFLAGS = \
> $(WNO_OVERRIDE_INIT) \
> $(LIBDRM_CFLAGS) \
> $(VALGRIND_CFLAGS) \
> - -msse2
> + -msse2 -mstackrealign
>
> AM_CXXFLAGS = $(AM_CFLAGS)
>
> --
> 2.7.4
>
Also, since this is extremely trivial and fixes bugs, this should
be cc'd to
mesa stable for 18.1 and 18.2
Thanks,
Dylan
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org <mailto:mesa-dev@lists.freedesktop.org>
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
<https://lists.freedesktop.org/mailman/listinfo/mesa-dev>
--
Sergii Romantsov
GlobalLogic Inc.
www.globallogic.com <http://www.globallogic.com/>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
