On Friday, 2018-09-21 16:29:48 +0100, Emil Velikov wrote:
> On 21 September 2018 at 14:46, Eric Engestrom <eric.engest...@intel.com> 
> wrote:
> > I also updated the developer instructions; presumably someone who's been
> > given commit rights already knows how to clone a repository :)
> >
> > A more useful thing is to show how to update the pushurl, and how to use
> > access tokens to push over HTTPS (especially for us at Intel, where
> > non-http traffic is a pain).
> >
> Personally I'd omit the Intel mention (in the documentation), but it's
> your call.

Dropped.

> For the series:
> Reviewed-by: Emil Velikov <emil.l.veli...@gmail.com>

Thanks!

> 
> Unrelated: I wish gitlab would stop redirecting when the clone URL is
> missing the .git at the end.
> The redirection message git throws is fairly annoying :-\

Agreed :/
If it already figured out that it's replying a git client, it could just
do the right thing silently, like GitHub does, where having the .git at
the end of the repo url makes no difference for the client.

> 
> Thanks
> Emil
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to