https://bugs.freedesktop.org/show_bug.cgi?id=106833

Tapani Pälli <lem...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Tapani Pälli <lem...@gmail.com> ---
Fixed by following commit. Note that since the rule applies to ES only, this
fixes the conformance when running chrome with '--use-gl=egl'. Let me know if
this is not sufficient from Chrome or WebGL perspective. It could be the Angle
needs to be fixed when running on desktop GL.

--- 8< ---
commit 27f1298b9d95899c4061294e384fadfd1c0a1b44
Author: Tapani Pälli <tapani.pa...@intel.com>
Date:   Wed Jun 6 14:19:16 2018 +0300

    glsl/linker: validate attribute aliasing before optimizations

    Patch does a 'dry run' of assign_attribute_or_color_locations before
    optimizations to catch cases where we have aliasing of unused attributes
    which is forbidden by the GLSL ES 3.x specifications.

    We need to run this pass before unused attributes may be removed and with
    attribute binding information from program, therefore we re-use existing
    pass in linker rather than attempt to write another one.

    This fixes WebGL2 test 'gl-bindAttribLocation-aliasing-inactive' and
    Piglit test 'gles-3.0-attribute-aliasing'.

    Signed-off-by: Tapani Pälli <tapani.pa...@intel.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106833
    Reviewed-by: Timothy Arceri <tarc...@itsqueeze.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to