Eric Engestrom <eric.engest...@intel.com> writes: > On Thursday, 2018-11-15 19:01:24 +0100, Gert Wollny wrote: >> Emulate MESA_FORMAT_R_SRGB8 by using L8_UNORM_SRGB. This is possible >> because component swizzling is handled based on the mesa format and, >> hence, the a r001 swizzling can be used to correct the components. >> >> Enables and makes pass (tested on Kabylake) >> >> dEQP-GLES31.functional.srgb_texture_decode.skip_decode.sr8.* >> dEQP-GLES31.functional.texture.filtering.cube_array.formats.sr8* >> >> Signed-off-by: Gert Wollny <gert.wol...@collabora.com> > > Patches 1-3 are: > Reviewed-by: Eric Engestrom <eric.engest...@intel.com> > > Patch 4 is: > Acked-by: Eric Engestrom <eric.engest...@intel.com>
For external contributors, patches like this should not be R-B or Acked unless they have been tested in the i965 CI. This series failed to build when pushed, and regressed many tests when the compilation error was corrected. https://bugs.freedesktop.org/show_bug.cgi?id=108805 Gert, we can set up a CI build for you if you feel like it would be helpful to your work. Eric can also test your patches by pushing them to his CI project. >> --- >> src/mesa/drivers/dri/i965/brw_surface_formats.c | 1 + >> src/mesa/drivers/dri/i965/intel_extensions.c | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/src/mesa/drivers/dri/i965/brw_surface_formats.c >> b/src/mesa/drivers/dri/i965/brw_surface_formats.c >> index 879cb42453..77476a8c7e 100644 >> --- a/src/mesa/drivers/dri/i965/brw_surface_formats.c >> +++ b/src/mesa/drivers/dri/i965/brw_surface_formats.c >> @@ -67,6 +67,7 @@ brw_isl_format_for_mesa_format(mesa_format mesa_format) >> [MESA_FORMAT_B8G8R8A8_SRGB] = ISL_FORMAT_B8G8R8A8_UNORM_SRGB, >> [MESA_FORMAT_R8G8B8A8_SRGB] = ISL_FORMAT_R8G8B8A8_UNORM_SRGB, >> [MESA_FORMAT_B8G8R8X8_SRGB] = ISL_FORMAT_B8G8R8X8_UNORM_SRGB, >> + [MESA_FORMAT_R_SRGB8] = ISL_FORMAT_L8_UNORM_SRGB, >> [MESA_FORMAT_L_SRGB8] = ISL_FORMAT_L8_UNORM_SRGB, >> [MESA_FORMAT_L8A8_SRGB] = ISL_FORMAT_L8A8_UNORM_SRGB, >> [MESA_FORMAT_SRGB_DXT1] = ISL_FORMAT_BC1_UNORM_SRGB, >> diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c >> b/src/mesa/drivers/dri/i965/intel_extensions.c >> index d7e02efb54..6ec6248a70 100644 >> --- a/src/mesa/drivers/dri/i965/intel_extensions.c >> +++ b/src/mesa/drivers/dri/i965/intel_extensions.c >> @@ -113,6 +113,7 @@ intelInitExtensions(struct gl_context *ctx) >> ctx->Extensions.EXT_texture_snorm = true; >> ctx->Extensions.EXT_texture_sRGB = true; >> ctx->Extensions.EXT_texture_sRGB_decode = true; >> + ctx->Extensions.EXT_texture_sRGB_R8 = true; >> ctx->Extensions.EXT_texture_swizzle = true; >> ctx->Extensions.EXT_texture_type_2_10_10_10_REV = true; >> ctx->Extensions.EXT_vertex_array_bgra = true; >> -- >> 2.19.1 >> >> _______________________________________________ >> mesa-dev mailing list >> mesa-dev@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/mesa-dev > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev