From: Emil Velikov <emil.veli...@collabora.com>
We had cases where people would list old/invalid sha in the commit.
Add a trivial checker to catch those and throw a warning.
CC: Andres Gomez <ago...@igalia.com>
CC: Juan A. Suarez <jasua...@igalia.com>
CC: Dylan Baker <dy...@pnwbakers.com>
CC: mesa-sta...@lists.freedesktop.org
Signed-off-by: Emil Velikov <emil.veli...@collabora.com>
---
bin/get-pick-list.sh | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/bin/get-pick-list.sh b/bin/get-pick-list.sh
index 08a783f35a8..79b7a295ea6 100755
--- a/bin/get-pick-list.sh
+++ b/bin/get-pick-list.sh
@@ -38,6 +38,17 @@ is_sha_nomination()
if test $fixes_count -eq 0; then
return 1
fi
+
+ # Throw a warning for each invalid sha
+ while test $fixes_count -gt 0; do
+ # Treat only the current line
+ id=`echo "$fixes" | tail -n $fixes_count | head -n 1 | cut -d :
-f 2`
+ fixes_count=$(($fixes_count-1))
+ if ! git show $id &>/dev/null; then
+ echo WARNING: Commit $1 lists invalid sha $id
+ fi
+ done
+
return 0
}
--
2.19.2
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
