Timothy Arceri <tarc...@itsqueeze.com> writes:

> The functional change here is moving the nir_lower_io_to_scalar_early()
> calls inside st_nir_link_shaders() and moving the st_nir_opts() call
> after the call to nir_lower_io_arrays_to_elements().
>
> This fixes a bug with the following piglit test due to the current code
> not cleaning up dead code after we lower arrays. This was causing an
> assert in the new duplicate varyings link time opt introduced in
> 70be9afccb23.
>
> tests/spec/glsl-1.10/execution/vsfs-unused-array-member.shader_test
>
> Moving the nir_lower_io_to_scalar_early() calls also allows us to tidy
> up the code a little and merge some loops.

I love the reduction in stage tracking logic.

Reviewed-by: Eric Anholt <e...@anholt.net>

Attachment: signature.asc
Description: PGP signature

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to