Hi, Thanks!
I finally got CI results with ALL relevant tests and my implementation
works on everything but Haswell.
So I'll fix whatever is wrong there (hope that's just something small)
and send the final version.
There are still some tests for VK-GL-CTS which are not merged in master e.g.
https://github.com/KhronosGroup/VK-GL-CTS/pull/136 and there are some
unpublished tests for VK_EXT_conditional_rendering from other devs
which I have no idea when will be merged. I don't think this will
prevent merging my patches but still I would be more confident if CI
have ALL tests.
And yes, I also was quite slow with my patches.
On 1/8/19 11:13 AM, Erik Faye-Lund wrote:
On Wed, 2018-10-17 at 14:58 +0300, Danylo Piliaiev wrote:
This series implement VK_KHR_draw_indirect_count and
VK_EXT_conditional_rendering extensions.
They are implemented together because they are highly interweaved.
There are already tests in VK_CTS for VK_KHR_draw_indirect_count and
I made a pull request with
the tests for VK_EXT_conditional_rendering (
https://github.com/KhronosGroup/VK-GL-CTS/pull/131).
VK_KHR_draw_indirect_count is implemented for gen7+.
VK_EXT_conditional_rendering is implemented for gen7.5+ because it
requires MI_MATH to be
implemented correctly.
Since part of the tests aren't in VK-GL-CTS master I'm not sure how
to test the implementation
of VK_EXT_conditional_rendering with my tests on CI. Could anyone
help me with this?
Also the one thing I'm uncertain of is described in the last patch.
Many thanks to Jason Ekstrand for the help with the extensions.
Hey, great work :)
What's holding this series back? I'm very interested in this
functionality due to my work on Zink... :)
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
