On 2/14/19 2:41 PM, Andres Gomez wrote:
On Thu, 2019-02-14 at 14:31 +0200, Tapani Pälli wrote:
LGTM

Reviewed-by: Tapani Pälli <tapani.pa...@intel.com>

Thanks for the review, Tapani ☺


On 2/12/19 2:17 PM, Andres Gomez wrote:
Instead of generating a GL_INVALID_ENUM error when the type or format
is incorrect while using glClear{Named}Buffer{Sub}Data, generate
GL_INVALID_VALUE.

  From page 72 (page 94 of the PDF) of the OpenGL 4.6 spec:

Not sure what is the PDF referred there but in the PDF I have
(glspec46.core.pdf) these error values are specified on page 72.

Maybe I should stop writing the actual page in the PDF. I was following
the example of other references from previous commits and different
developers.

It is indeed page 72, as I also wrote.

What I mean is that, before the numbering starts in the document, there
are still another 22 pages so, basically, "page 1", in the PDF, is page
23.


Right yeah ... not sure if it brings real value but for consistency why not :)

// Tapani
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to