On Mon, 25 Feb 2019 at 17:59, Hota, Alok <alok.h...@intel.com> wrote: > > > -----Original Message----- > > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > > Sent: Monday, February 11, 2019 7:04 AM > > To: Hota, Alok <alok.h...@intel.com> > > Cc: mesa-dev@lists.freedesktop.org; mesa-sta...@lists.freedesktop.org > > Subject: Re: [Mesa-dev] [PATCH 1/2] swr/rast: don't create wrapper for > > every Create LLVM call > > > > On Mon, 4 Feb 2019 at 17:04, Hota, Alok <alok.h...@intel.com> wrote: > > > > > > > -----Original Message----- > > > > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > > > > Behalf Of Emil Velikov > > > > Sent: Monday, February 4, 2019 3:21 AM > > > > To: mesa-dev@lists.freedesktop.org > > > > Cc: mesa-sta...@lists.freedesktop.org; emil.l.veli...@gmail.com; > > > > Hota, Alok <alok.h...@intel.com> > > > > Subject: [Mesa-dev] [PATCH 1/2] swr/rast: don't create wrapper for > > > > every Create LLVM call > > > > > > > > We user only a fraction (approximatelly 1/4) of the API - generate only > > those. > > > > > > > > This way, we spend less time processing and generate smaller file. > > > > This also removes the need for hacks needed for compiling files > > > > bootstrapped with another LLVM version. > > > > > > Thanks for the patch! > > > I had to add one function, CreateNeg, to used_functions for it to compile > > for me. > > > > > Thanks, can I consider this a Tested-by? > > A review or even an ack from SWR developers would also be appreciated. > > Sorry to let this hang for so long. > After some review, it looks like we have some upcoming changes internally > that would be complicated with this change, and with this approach. At the > time, I think we will hold off on this change, though I will be keeping it in > mind.
Can you elaborate what seems to be the problem? I'm more than happy to rework the patch so it works for you guys - do you have a WIP branch somewhere? Thanks Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
