[Mesa-dev] [PATCH 17/34] nv50/ir/nir: implement nir_intrinsic_store_(per_vertex_)output

[Karol Herbst]

v3: add workaround for RA issues
    indirects have to be multiplied by 0x10
    fix indirect access
v4: use smarter getIndirect helper
    use storeTo helper
v5: don't use const_offset directly
v8: don't require C++11 features
v9: convert to C++ style comments
    handle clip planes correctly

Signed-off-by: Karol Herbst <kher...@redhat.com>
---
 .../nouveau/codegen/nv50_ir_from_nir.cpp      | 57 ++++++++++++++++++-
 1 file changed, 56 insertions(+), 1 deletion(-)

diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp 
b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
index dc8dbcfb48b..6e26e00d91f 100644
--- a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
+++ b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp
@@ -145,6 +145,8 @@ private:
    BasicBlock *exit;
    Value *zero;
 
+   int clipVertexOutput;
+
    union {
       struct {
          Value *position;
@@ -155,7 +157,8 @@ private:
 Converter::Converter(Program *prog, nir_shader *nir, nv50_ir_prog_info *info)
    : ConverterCommon(prog, info),
      nir(nir),
-     curLoopDepth(0)
+     curLoopDepth(0),
+     clipVertexOutput(-1)
 {
    zero = mkImm((uint32_t)0);
 }
@@ -1082,9 +1085,16 @@ bool Converter::assignSlots() {
          case TGSI_SEMANTIC_CLIPDIST:
             info->io.genUserClip = -1;
             break;
+         case TGSI_SEMANTIC_CLIPVERTEX:
+            clipVertexOutput = vary;
+            break;
          case TGSI_SEMANTIC_EDGEFLAG:
             info->io.edgeFlagOut = vary;
             break;
+         case TGSI_SEMANTIC_POSITION:
+            if (clipVertexOutput < 0)
+               clipVertexOutput = vary;
+            break;
          default:
             break;
          }
@@ -1346,6 +1356,11 @@ Converter::visit(nir_function *function)
 
    setPosition(entry, true);
 
+   if (info->io.genUserClip > 0) {
+      for (int c = 0; c < 4; ++c)
+         clipVtx[c] = getScratch();
+   }
+
    switch (prog->getType()) {
    case Program::TYPE_TESSELLATION_CONTROL:
       outBase = mkOp2v(
@@ -1372,6 +1387,9 @@ Converter::visit(nir_function *function)
    bb->cfg.attach(&exit->cfg, Graph::Edge::TREE);
    setPosition(exit, true);
 
+   if (info->io.genUserClip > 0)
+      handleUserClipPlanes();
+
    // TODO: for non main function this needs to be a OP_RETURN
    mkOp(OP_EXIT, TYPE_NONE, NULL)->terminator = 1;
    return true;
@@ -1542,6 +1560,43 @@ Converter::visit(nir_intrinsic_instr *insn)
       }
       break;
    }
+   case nir_intrinsic_store_output:
+   case nir_intrinsic_store_per_vertex_output: {
+      Value *indirect;
+      DataType dType = getSType(insn->src[0], false, false);
+      uint32_t idx = getIndirect(insn, op == nir_intrinsic_store_output ? 1 : 
2, 0, indirect);
+
+      for (uint8_t i = 0u; i < insn->num_components; ++i) {
+         if (!((1u << i) & nir_intrinsic_write_mask(insn)))
+            continue;
+
+         uint8_t offset = 0;
+         Value *src = getSrc(&insn->src[0], i);
+         switch (prog->getType()) {
+         case Program::TYPE_FRAGMENT: {
+            if (info->out[idx].sn == TGSI_SEMANTIC_POSITION) {
+               // TGSI uses a different interface than NIR, TGSI stores that
+               // value in the z component, NIR in X
+               offset += 2;
+               src = mkOp1v(OP_SAT, TYPE_F32, getScratch(), src);
+            }
+            break;
+         }
+         case Program::TYPE_VERTEX: {
+            if (info->io.genUserClip > 0 && idx == clipVertexOutput) {
+               mkMov(clipVtx[i], src);
+               src = clipVtx[i];
+            }
+            break;
+         }
+         default:
+            break;
+         }
+
+         storeTo(insn, FILE_SHADER_OUTPUT, OP_EXPORT, dType, src, idx, i + 
offset, indirect);
+      }
+      break;
+   }
    default:
       ERROR("unknown nir_intrinsic_op %s\n", nir_intrinsic_infos[op].name);
       return false;
-- 
2.20.1

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev