Oliver, There will be other system values in the future, so instead of passing every value as a different parameter, please define a structure in src/gallium/auxiliary/gallivm/lp_bld_tgsi.h as
struct lp_bld_tgsi_system_values { LLVMValueRef facing; LLVMValueRef instance_id; LLVMValueRef vertex_id; ... } which is then passed to lp_build_tgsi_soa and all other functions. Otherwise the change looks good overall. Jose ----- Original Message ----- > Hi, > > The following pair of patches add gl_VertexID support to llvmpipe. > They also simplify the system value fetch methodology (hopefully > generating better code in the end) and fixes some issues with > gl_InstanceID. The "I don't understand how it could ever work" kind > of issues, converting from int32 to float twice is not good, usually. > > Best, > > OG. > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev