Sorry for the delay, I've now pushed this. Roland
Am 21.11.19 um 06:31 schrieb Zebediah Figura: > Ping? > > On 11/5/19 10:21 AM, Zebediah Figura wrote: >> This reverts commit f97b731c82afb06cfd6ffebc90a3e098a9a1b308. >> >> Closes: >> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Fmesa%2Fmesa%2Fissues%2F250&data=02%7C01%7Csroland%40vmware.com%7C1ebdc9c211964ad8e85608d76e442549%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C1%7C637099111319407572&sdata=sbYBdsE15KRre2Vivfhcd5Bv34CWnJiJZn5Xes4OnqM%3D&reserved=0 >> --- >> Corresponding piglit test patch: >> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.freedesktop.org%2Fpatch%2F338747%2F&data=02%7C01%7Csroland%40vmware.com%7C1ebdc9c211964ad8e85608d76e442549%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C1%7C637099111319407572&sdata=VoCucwYTyU16XDnUX%2FHne8dKHLfF1Q5uwp0OwSJWMF4%3D&reserved=0 >> >> This is my first patch to Mesa. I do not have commit access. >> >> src/gallium/auxiliary/draw/draw_pt_decompose.h | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/src/gallium/auxiliary/draw/draw_pt_decompose.h >> b/src/gallium/auxiliary/draw/draw_pt_decompose.h >> index c4fab6548b..0b2522c08f 100644 >> --- a/src/gallium/auxiliary/draw/draw_pt_decompose.h >> +++ b/src/gallium/auxiliary/draw/draw_pt_decompose.h >> @@ -3,8 +3,6 @@ >> const boolean quads_flatshade_last = \ >> draw->quads_always_flatshade_last; \ >> const boolean last_vertex_last = \ >> - !(draw->rasterizer->flatshade && \ >> - draw->rasterizer->flatshade_first); >> -/* FIXME: the draw->rasterizer->flatshade part is really wrong */ >> + !draw->rasterizer->flatshade_first; >> >> #include "draw_decompose_tmp.h" >> > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fmesa-dev&data=02%7C01%7Csroland%40vmware.com%7C1ebdc9c211964ad8e85608d76e442549%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C1%7C637099111319407572&sdata=Tr6q6Y1jtulZWiN2QTR4d3viF1Ai7F5cD0zHOZb9X8I%3D&reserved=0 > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev