This all sounds find to me, FWIW.
-Brian
On 09/19/2020 04:24 AM, Marek Olšák wrote:
Hi,
I don't know if you have been following gitlab, but there are a few
cleanups that I have been considering doing.
Rename PIPE_TRANSFER flags to PIPE_MAP, and pipe_transfer_usage to
pipe_map_flags:
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5749
<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Fmesa%2Fmesa%2F-%2Fmerge_requests%2F5749&data=02%7C01%7Cbrianp%40vmware.com%7Cbedfd0817f704e06e75808d85c863fb3%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637361078970577405&sdata=7Nyd8ufSCAfWo1kBYPE%2Fta7aOKy1p%2BZ529GcejP4keY%3D&reserved=0>
Other proposed renames:
transfer_map -> resource_map
transfer_unmap -> resource_unmap
transfer_flush_region -> resource_flush_mapped_range
draw_vbo -> draw
pipe_transfer_* aux helpers -> pipe_resource_* or pipe_texture_*
depending on context. We already have pipe_buffer_map.
I'm inclined to keep the struct pipe_transfer name unchanged to indicate
that mappings can cause internal copies.
Please let me know your preferences.
Thanks,
Marek
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fmesa-dev&data=02%7C01%7Cbrianp%40vmware.com%7Cbedfd0817f704e06e75808d85c863fb3%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637361078970597391&sdata=qI2%2BFMvRDEIePjAOjbGVwCOusUxyw6I1wwL7fJb%2Blgs%3D&reserved=0
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
