-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 08/06/2012 11:05 AM, Eric Anholt wrote: > Chad Versace <[email protected]> writes: > >> Add the following fields: singlesamle_width0 singlesample_height0 >> singlesample_mt needs_downsample >> >> These will all be used by later commits that implement MSAA for window >> system buffers. > > I really don't like splitting the commits for creation of fields from their > usage. I was pretty convinced that singlesample_width0/height0 wasn't > needed (since it should just be in singlesample_mt, right?) until I > searched later in the commit series to find the singlesample_tmp flag, > which is introduced in the appropriate commit. >
Done. In series v3, I declare each field in the first commit that uses it. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJQIF9gAAoJEAIvNt057x8i2GIP/Rywo/F9nlP+MBB3Md/N3SU0 UoJqCy/QTrDsWqp6efQADQw5V7pcG+FXlfAej8A1bIBhxER5G+829JJpRNmopiZf 9J1QqYV5i3imVyCsU5jVjrlHDzHGOO9Qx8BOv33w1+i/EgJnigVmmG36GfeMWEbA m8S0tjAEAfX3EEkbabfvHQp9prDXOAseOBoQgGaZNS7+l6v9B2Xen8JLT6v3hds0 HNJwnVbl/KJM0E96WdZPWSzSwyDKL4RA+z12XRo9j9JdmGwCo05pwXIoPBqbHwi6 3+yCvjwoetDyTXqAR7cwli5cHbdth/Omvkyr+kXdDM1+GGSK8V4c7nAwk1YwM7ed qaY+8qCZ9iATWPWiU+vLbLxVUNQbwTyUxr0vvlnsy4gJJFzV4fK2DVnBlCxdXk9K iCI6D1/VcuXMztoR/suBQmoastnJwTwBTN++PaUebzok9l6L8GctP2N3P/ZrDRVW V2ZZ/7VK9TlnYPMmDCmBdT4cStA3A+vA4/PCR4a/b0c7VC6QyJHQJ/aDXXq/LLWc NRc8MWBHH1iAKMOwWlImPQKSSFfe3Md4hKrSvGA/4GziUJF2b6ugInMgCCuqGPZR MiHJWu2ZL62M+opU5YoTHgZBMPe3fdAnxPi7Bf/gzq35XLduBhZpnCOn4e8Z/2dL VO/4KA5eStw1R3H9+DBB =3V+B -----END PGP SIGNATURE----- _______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
