On Sat, Aug 11, 2012 at 4:11 AM, Ian Romanick <i...@freedesktop.org> wrote: > On 08/09/2012 07:52 PM, Marek Olšák wrote: >> >> On Fri, Aug 10, 2012 at 3:42 AM, Ian Romanick <i...@freedesktop.org> wrote: >>> >>> On 08/08/2012 10:53 AM, Brian Paul wrote: >>>> >>>> >>>> On 08/08/2012 11:38 AM, Ian Romanick wrote: >>>>> >>>>> >>>>> From: Ian Romanick<ian.d.roman...@intel.com> >>>>> >>>>> Signed-off-by: Ian Romanick<ian.d.roman...@intel.com> >>>>> --- >>>>> src/mesa/main/extensions.c | 24 ++++++++++++------------ >>>>> 1 files changed, 12 insertions(+), 12 deletions(-) >>>>> >>>>> diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c >>>>> index 5115d42..cca1eac 100644 >>>>> --- a/src/mesa/main/extensions.c >>>>> +++ b/src/mesa/main/extensions.c >>>>> @@ -88,7 +88,7 @@ static const struct extension extension_table[] = { >>>>> { "GL_ARB_debug_output", >>>>> o(dummy_true), GL, 2009 }, >>>>> { "GL_ARB_depth_buffer_float", >>>>> o(ARB_depth_buffer_float), GL, 2008 }, >>>>> { "GL_ARB_depth_clamp", >>>>> o(ARB_depth_clamp), GL, 2003 }, >>>>> - { "GL_ARB_depth_texture", >>>>> o(ARB_depth_texture), GL, 2001 }, >>>>> + { "GL_ARB_depth_texture", >>>>> o(ARB_depth_texture), GLL, 2001 }, >>>>> { "GL_ARB_draw_buffers", >>>>> o(dummy_true), GL, 2002 }, >>>>> { "GL_ARB_draw_buffers_blend", >>>>> o(ARB_draw_buffers_blend), GL, 2009 }, >>>>> { "GL_ARB_draw_elements_base_vertex", >>>>> o(ARB_draw_elements_base_vertex), GL, 2009 }, >>>>> @@ -109,7 +109,7 @@ static const struct extension extension_table[] = { >>>>> { "GL_ARB_occlusion_query2", >>>>> o(ARB_occlusion_query2), GL, 2003 }, >>>>> { "GL_ARB_occlusion_query", >>>>> o(ARB_occlusion_query), GL, 2001 }, >>>>> { "GL_ARB_pixel_buffer_object", >>>>> o(EXT_pixel_buffer_object), GL, 2004 }, >>>>> - { "GL_ARB_point_parameters", >>>>> o(EXT_point_parameters), GL, 1997 }, >>>>> + { "GL_ARB_point_parameters", >>>>> o(EXT_point_parameters), GLL, 1997 }, >>>>> { "GL_ARB_point_sprite", >>>>> o(ARB_point_sprite), GL, 2003 }, >>>>> { "GL_ARB_provoking_vertex", >>>>> o(EXT_provoking_vertex), GL, 2009 }, >>>>> { "GL_ARB_robustness", >>>>> o(dummy_true), GL, 2010 }, >>>>> @@ -121,7 +121,7 @@ static const struct extension extension_table[] = { >>>>> { "GL_ARB_shader_texture_lod", >>>>> o(ARB_shader_texture_lod), GL, 2009 }, >>>>> { "GL_ARB_shading_language_100", >>>>> o(ARB_shading_language_100), GLL, 2003 }, >>>>> { "GL_ARB_shadow_ambient", >>>>> o(ARB_shadow_ambient), GL, 2001 }, >>>> >>>> >>>> >>>> I think GL_ARB_shadow_ambient would go hand-in-hand with GL_ARB_shadow. >>> >>> >>> I didn't include that extension because it never became part of any GL >>> version. It's just an extension. I believe that Radeon hardware >>> supports >>> this natively. Everyone else would need to add a MAX instruction in the >>> shader, so nobody ever bothered. Realistically, it's only useful with >>> fixed >>> function. >> >> >> The extension doesn't seem to be enabled on *any* hardware driver >> whatsoever. It was decided that Gallium wouldn't implement it, because >> the extension was considered not very useful back then and much less >> now. > > > I'd swear that r300c used to support it (and Apple still does in legacy
Yes, r300c emulated it in fragment shaders just like ARB_shadow. There was no support for texture compare modes in that hardware. > OpenGL mode). Either way, I think we're in violent agreement. I'll submit > a follow-on patch that removes all traces of GL_ARB_shadow_ambient. There's > no use keeping any of it around if nobody supports it. Sounds good. Marek _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev