On Thu, Sep 6, 2012 at 5:21 PM, Philipp Klaus Krause <p...@spth.de> wrote:
> On 06.09.2012 07:35, j.gli...@gmail.com wrote:
>> From: Jerome Glisse <jgli...@redhat.com>
>>
>> To avoid GPU lockup registers must be emited in a specific order
>> (no kidding ...). This patch rework atom emission so order in which
>> atom are emited in respect to each other is always the same. We
>> don't have any informations on what is the correct order so order
>> will need to be infered from fglrx command stream.
>
> Shouldn't this be stated in comments, so the next person who comes along
> and makes a change in this code doesn't inadvertently change the order?

Also a comment on what ordering matters most, like I suspect this is
just hiding a real issue.

Dave.
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to