On 10/04/2012 03:42 PM, Marek Olšák wrote:
No idea why this is #ifdef'd. Trace and Noop are definitely useful no matter how Mesa is built. --- .../auxiliary/target-helpers/inline_debug_helper.h | 8 -------- 1 file changed, 8 deletions(-)diff --git a/src/gallium/auxiliary/target-helpers/inline_debug_helper.h b/src/gallium/auxiliary/target-helpers/inline_debug_helper.h index 43a7249..77c7cfd 100644 --- a/src/gallium/auxiliary/target-helpers/inline_debug_helper.h +++ b/src/gallium/auxiliary/target-helpers/inline_debug_helper.h @@ -10,8 +10,6 @@ * one or more debug driver: rbug, trace. */ -#ifdef DEBUG - #ifdef GALLIUM_TRACE #include "trace/tr_public.h" #endif @@ -28,13 +26,9 @@ #include "noop/noop_public.h" #endif -#endif /* DEBUG */ - static INLINE struct pipe_screen * debug_screen_wrap(struct pipe_screen *screen) { -#ifdef DEBUG - #if defined(GALLIUM_RBUG) screen = rbug_screen_create(screen); #endif @@ -51,8 +45,6 @@ debug_screen_wrap(struct pipe_screen *screen) screen = noop_screen_create(screen); #endif -#endif /* DEBUG */ - return screen; }
Looks OK to me. Reviewed-by: Brian Paul <[email protected]> _______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
