On 12/08/2012 03:48 AM, Jose Fonseca wrote:
Reviewed-by: Jose Fonseca<jfons...@vmware.com>

Series looks excellent Brian. Thanks for nailing this issue. I never stop to be 
amazed on how state derivation bugs go unnoticed for so long, just because most 
apps ends up touch a lot of state at the same time. One could try to write 
piglit tests that draw something, change one bit of state, re-draw, but it 
would take a lot of tests to cover everything.

Slight different issue -- you originally were looking into draw module and user 
buffer pointers -- is draw module actually properly flushing whenever user 
buffers are used? Or is that still outstanding?

That's separate. I have a fix for that too, but I need to rebase it on top of these changes, retest, etc.

-Brian
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to