On Thu, Feb 7, 2013 at 3:37 AM, Jose Fonseca <jfons...@vmware.com> wrote: > > > ----- Original Message ----- >> On Wed, Feb 6, 2013 at 4:30 PM, Kristian Høgsberg <k...@bitplanet.net> >> wrote: >> > On Tue, Feb 5, 2013 at 8:43 AM, <jfons...@vmware.com> wrote: >> >> From: José Fonseca <jfons...@vmware.com> >> >> >> >> I'd like to test Mesa OpenGL ES along side with NVIDIA libGL >> >> drivers. But >> >> without this change, I get a NULL pointer dereference. >> > >> > Which DRI driver doesn't support the flush extension? EGL is >> > expected >> > to flush before swap buffer (and we can't rely on glFLush since >> > that >> > may be optimized to not do anything) so we have to have this DRI >> > driver entry point. The EGL DRI loader shouldn't load a DRI driver >> > that doesn't support the flush extension in the first place, of >> > course. > > I was using EGL GLES swrast, but on a system with proprietary NVIDIA drivers > installed.
Ok, right, swrast doesn't have a flush extension and we don't look for it in case of swrast. Maybe it would be clearer to do if (!dri2_dpy->swrast) dri2_dpy->flush->flush(dri2_surf->dri_drawable); to make it clearer that we don't require the flush extension for swrast. Though a deferred/tile sw rasterizer would need a flush extension too to know when to kick off the rendering. Anyway since we do make sure we have a flush extension in the !swrast case, I guess what you have now is fine. Kristian _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev