Matt Turner <matts...@gmail.com> writes: > I believe that prog can only be NULL for ARB programs. Neither > brw_fs_fp.cpp nor brw_vec4_vp.cpp call fail(), but not NULL checking > prog is obviously fragile.
(shader != NULL) <=> (prog != NULL), so if you want consistency I'd rather see the if (shader) changed to if (prog). A bunch of these changes are not about compilation failure, anyway.
pgpRBXfgm3b05.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev