On 04/09/2013 10:49 AM, Eric Anholt wrote:
Ian Romanick <i...@freedesktop.org> writes:
This series gradually replaces array dereferences of vectors with two
expressions. It takes so many patches because changes are needed to the
existing lowering passes and because several places in the code generate
array dereferences of vectors (e.g., lowering accessed to
gl_ClipDistance). There is also some challenge in dealing with function
inout parameters that are indexed vectors.
The two new expressions are ir_binop_vector_extract and
ir_triop_vector_insert. The former has a vector operand and a scalar
operand. The result is the scalar value from the vector specified by
the scalar. The later takes a vector and two scalars. The result is a
new vector with one indexed field replaced by a scalar value.
Together this series fixes piglit tests glsl-vs-channel-overwrite-01 and
glsl-vs-channel-overwrite-03.
Throughout the series, there's a bunch of introduction of new tabs for
indentation. Paul pointed out long ago that the devinfo.html had
specified a no-tabs indent style in the indent command since 2006, and I
found that basically you and I were the only ones putting tabs in, so I
stopped. I've found reading diffs has become easier since avoiding
tabs, since you don't get diffs with apparently-incorrect indentation
(thanks to "> +" being 3 sharacters, in particular).
I'd love to see this code fixed to not use tabs. If you use emacs,
removing your custom configuration for Mesa and relying on
.dir-locals.el will get you the preferred style for future work.
Other than that, the patches other than the ones I commented on and the
gl_ClipDistance ones are:
Reviewed-by: Eric Anholt <e...@anholt.net>
I've pushed a branch with updated patches to
http://cgit.freedesktop.org/~idr/mesa/log/?h=vector
Let me know if the changes to patches 6 and 8 are sufficient.
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
