On 04/09/2013 03:11 PM, Paul Berry wrote:
Changes since v1:
- Consistently use the variable name "shader_prog" to refer to struct
gl_shader_program and "prog" to refer to struct gl_program.
- Move urb_read_length and urb_entry_size into brw_vec4_prog_data so
that they can be re-used by geometry shaders.
- When vec4_vs_visitor has a pointer to a VS-specific data structure,
and vec4_visitor has a pointer to the generic version of that data
structure, use a short variable name in vec4_visitor and a longer
variable name in vec4_vs_visitor.
I've updated the branch "gs-backend-prep" on
git://github.com/stereotype441/mesa.git to point to v2 of the series.
You can ignore my comments on patch 8.
Other than my small comments on patch 9 (which you're free to take or
leave), this series is:
Reviewed-by: Kenneth Graunke <kenn...@whitecape.org>
It'd also be nice to see the brw_vs_compile struct die now that it's
basically empty, but it sounds like Eric's going to take care of that as
a follow-up patch.
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
