Brian Paul <bri...@vmware.com> writes: > On 06/26/2013 04:33 PM, Eric Anholt wrote: >> Brian Paul <bri...@vmware.com> writes: >> >>> On 06/26/2013 03:56 PM, Ian Romanick wrote: >>>> Patches 1 and 4 are >>>> >>>> Reviewed-by: Ian Romanick <ian.d.roman...@intel.com> >>>> >>>> For patch 3, I share Jose's concern. I would very much like to see this >>>> happen in directories containing code that will be built with MSVC. >>> >>> Yeah, sounds good, but off-hand I have no idea how to do this per-directory. >> >> Just add it to AM_CPPFLAGS in the directories you care about. > > But only if the compiler is gcc, right? Something like: > > if GCC > AM_CPPFLAGS += "-Wdeclaration-after-statement" > endif
Just like we do other compiler-dependent stuff -- detect compiler in configure.ac, AC_SUBST a variable conditionally containing the flag, then use it where you want. Actually, this would need to be AM_CFLAGS and AM_CXXFLAGS, since it's a compiler option, not a preprocessor option. VISIBILITY_CFLAGS would be an example.
pgpsvIeyUbBCH.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
