On 26 August 2013 22:00, Matt Turner <matts...@gmail.com> wrote:
> Thanks Paul.
>
> I've placed this patch as 2.5/15 in the series.
>
> i965/fs: Assert that ir_expressions are usable by 3-src instructions
>
> MAD will be generated directly from ir_triop_fma, so this assertion
> checks that all ir_expressions are usable.
>
Reviewed-by: Paul Berry <stereotype...@gmail.com>
> ---
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
> b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
> index 27887d6..a02d92d 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
> @@ -336,6 +336,7 @@ fs_visitor::visit(ir_expression *ir)
> ir->operands[operand]->print();
> printf("\n");
> }
> + assert(this->result.is_valid_3src());
>
I spent a while trying to think of a commet that could go above the assert,
to help someone who stumbles across it in the future and wonders why the
assertion is here rather than in the switch statement below, but I couldn't
really think of anything :(
> op[operand] = this->result;
>
> /* Matrix expression operands should have been broken down to vector
>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
