Am 29.08.2013 12:38, schrieb Marek Olšák:
On Thu, Aug 29, 2013 at 12:20 PM, Christian König
<deathsim...@vodafone.de> wrote:
Am 28.08.2013 19:17, schrieb Marek Olšák:
This series contains the changes my transform feedback work depends on,
but there are some useful fixes too, making it worth comitting earlier.
The last patch is the most important one, because it fixes the issues we
had with the emission of resource descriptors that we had to use 256
resource contexts as a workaround. Further testing has shown that even 256
wasn't enough. With that patch, we only need 8 or 16 contexts as originally
expected.
I also made the first step towards sharing code between r600g and radeonsi
and it's what made this series so big:
54 files changed, 2448 insertions(+), 2532 deletions(-)
Please review.
Sounds good, one minor comment on patch 4:
Why did you named the common classes r600_common_* ? My feeling would go
more towards radeon_*
Apart from that the patches seem really good to me.
Thank you.
The radeon_ prefix would suggest to me that it supports any radeon
ASICs, including r300, which isn't true. I did use radeon_* at the
beginning, but it didn't feel right. The r600_ prefix clearly states
it only supports r600 and later ASICs.
Ok, sounds like a good argument. The only code sharing I need between
R300 and R600 would be for the UVD block on the RV515 and I have my
doubts that we ever get there to support it.
Christian.
Marek
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
