Kenneth Graunke <kenn...@whitecape.org> writes: > On 08/29/2013 04:06 PM, Eric Anholt wrote: >> emit_constants(3DSTATE_CONSTANT_VS, &brw->vs.stage_state); > > I'm fine with putting the constant emission into a helper function. > Although it's simple code, it's quite a few lines, so factoring it out > would make things more concise. All stages could easily reuse it. > > Plus, that function would have a single, obvious purpose - emit > 3DSTATE_CONSTANT_XS for some X.
That's actually what I'd prefer, too.
pgpcCxtCJczBs.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev