Clean up inconsistency in enum decoration: - Use the undecorated enums where possible. - MAX_PROGRAM_TEXTURE_GATHER_COMPONENTS_ARB remains decorated, since it has no undecorated equivalent in GL4.
Signed-off-by: Chris Forbes <chr...@ijw.co.nz> --- src/mapi/glapi/gen/ARB_texture_gather.xml | 6 ++++-- src/mapi/glapi/gen/Makefile.am | 1 + src/mesa/main/get_hash_params.py | 4 ++-- src/mesa/main/tests/enum_strings.cpp | 2 +- 4 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/mapi/glapi/gen/ARB_texture_gather.xml b/src/mapi/glapi/gen/ARB_texture_gather.xml index 01c7b88..41714ac 100644 --- a/src/mapi/glapi/gen/ARB_texture_gather.xml +++ b/src/mapi/glapi/gen/ARB_texture_gather.xml @@ -5,8 +5,10 @@ <category name="GL_ARB_texture_gather" number="72"> - <enum name="MIN_PROGRAM_TEXTURE_GATHER_OFFSET_ARB" value="0x8E5E"/> - <enum name="MAX_PROGRAM_TEXTURE_GATHER_OFFSET_ARB" value="0x8E5F"/> + <enum name="MIN_PROGRAM_TEXTURE_GATHER_OFFSET" value="0x8E5E"/> + <enum name="MAX_PROGRAM_TEXTURE_GATHER_OFFSET" value="0x8E5F"/> + + <!-- This exists only in the ARB extension; not in GL4 --> <enum name="MAX_PROGRAM_TEXTURE_GATHER_COMPONENTS_ARB" value="0x8F9F"/> </category> diff --git a/src/mapi/glapi/gen/Makefile.am b/src/mapi/glapi/gen/Makefile.am index 9b9b995..6bb2f1e 100644 --- a/src/mapi/glapi/gen/Makefile.am +++ b/src/mapi/glapi/gen/Makefile.am @@ -111,6 +111,7 @@ API_XML = \ ARB_texture_buffer_range.xml \ ARB_texture_compression_rgtc.xml \ ARB_texture_float.xml \ + ARB_texture_gather.xml \ ARB_texture_rg.xml \ ARB_texture_storage.xml \ ARB_vertex_array_object.xml \ diff --git a/src/mesa/main/get_hash_params.py b/src/mesa/main/get_hash_params.py index 29cad26..e80a23c 100644 --- a/src/mesa/main/get_hash_params.py +++ b/src/mesa/main/get_hash_params.py @@ -718,8 +718,8 @@ descriptor=[ [ "TEXTURE_BINDING_CUBE_MAP_ARRAY_ARB", "LOC_CUSTOM, TYPE_INT, TEXTURE_CUBE_ARRAY_INDEX, extra_ARB_texture_cube_map_array" ], # GL_ARB_texture_gather - [ "MIN_PROGRAM_TEXTURE_GATHER_OFFSET_ARB", "CONTEXT_INT(Const.MinProgramTextureGatherOffset), extra_ARB_texture_gather"], - [ "MAX_PROGRAM_TEXTURE_GATHER_OFFSET_ARB", "CONTEXT_INT(Const.MaxProgramTextureGatherOffset), extra_ARB_texture_gather"], + [ "MIN_PROGRAM_TEXTURE_GATHER_OFFSET", "CONTEXT_INT(Const.MinProgramTextureGatherOffset), extra_ARB_texture_gather"], + [ "MAX_PROGRAM_TEXTURE_GATHER_OFFSET", "CONTEXT_INT(Const.MaxProgramTextureGatherOffset), extra_ARB_texture_gather"], [ "MAX_PROGRAM_TEXTURE_GATHER_COMPONENTS_ARB", "CONTEXT_INT(Const.MaxProgramTextureGatherComponents), extra_ARB_texture_gather"], ]}, diff --git a/src/mesa/main/tests/enum_strings.cpp b/src/mesa/main/tests/enum_strings.cpp index 6994f79..8a3103b 100644 --- a/src/mesa/main/tests/enum_strings.cpp +++ b/src/mesa/main/tests/enum_strings.cpp @@ -1789,7 +1789,7 @@ const struct enum_info everything[] = { { 0x8F9C, "GL_SIGNED_NORMALIZED" }, { 0x8F9D, "GL_PRIMITIVE_RESTART" }, { 0x8F9E, "GL_PRIMITIVE_RESTART_INDEX" }, - { 0x8F9F, "GL_MAX_PROGRAM_TEXTURE_GATHER_COMPONENTS" }, + { 0x8F9F, "GL_MAX_PROGRAM_TEXTURE_GATHER_COMPONENTS_ARB" }, { 0x906F, "GL_RGB10_A2UI" }, { 0x9100, "GL_TEXTURE_2D_MULTISAMPLE" }, { 0x9101, "GL_PROXY_TEXTURE_2D_MULTISAMPLE" }, -- 1.8.4 _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev