Kenneth Graunke <kenn...@whitecape.org> writes: > BLORP performs blits by drawing a rectangle with a shader that samples > from the source texture, and writes color data to the destination. > > The sampler always returns 32-bit RGBA float data, regardless of the > source format's component ordering or data type. Likewise, the render > target write message takes 32-bit RGBA float data, and converts it > appropriately. So the bulk of the work is already taken care of for us. > > This greatly accelerates a lot of blits and CopyTexSubImage calls, and > makes Legends of Aethereus playable on Ivybridge. At the default > settings, LOA continually blits between SRGBA8888 (the window format) > and RGBA16_FLOAT. Since neither BLORP nor our BLT paths supported this, > it fell back to meta, spending 33% of the CPU in floorf() converting > between floats and half-floats.
Does this actually accelerate blits other than CopyTexSubImage calls? It looks like the old format equality checks are still in place for BlitFramebuffer. Other than the review provided by others, and possibly updating this message, this series is: Reviewed-by: Eric Anholt <e...@anholt.net>
pgpz9nVfUOtiO.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
