Paul Berry <stereotype...@gmail.com> writes: > On 4 October 2013 15:44, Eric Anholt <e...@anholt.net> wrote: > >> Now that both vec4 and fs are dynamically assigning offsets, a lot of the >> code is the same. >> --- >> > > Since next_binding_table_offset is only used to into > assign_common_binding_table_offsets(), I'd prefer to see it made into a > function argument rather than a class member. That way it wouldn't be > necessary to grep through the code to verify that no one else uses it. > > With that changed, this patch is: > > Reviewed-by: Paul Berry <stereotype...@gmail.com>
Thanks. I agree that's cleaner, too.
pgp6HYKMM5gSx.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
