On 11/27/2013 10:47 AM, Kenneth Graunke wrote: > On 11/23/2013 05:45 PM, Kenneth Graunke wrote: >> On 11/23/2013 04:03 PM, Ian Romanick wrote: >>> Would it be better to just make _mesa_glsl_get_builtin_function_shader a >>> friend? >> >> In this case, I don't think it makes much practical difference - the >> builtin_builder class is entirely contained within the >> builtin_functions.cpp file. So making this public is basically making >> all the ordinary functions at the bottom of the file friends, which >> seems fairly reasonable. >> >> --Ken > > Ian, after that answer, are you okay with the patch? Or would you like > it changed?
I don't have a strong opinion... since none of the more hard-core C++ guys spoke up, I'm fine with it as-is. Reviewed-by: Ian Romanick <ian.d.roman...@intel.com> > --Ken _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
