Hi again, it's about one week these patches are receiving feedback and they (v2) look fine to reviewers. May I send a v3 for final review?

Best regards,
Siavash Eliasi.

On 11/28/2013 12:26 PM, Siavash Eliasi wrote:
Hello, this is V2 series of patches to accomplish *Enable 
ARB_map_buffer_alignment in all drivers* newbie project suggested by Ian 
Romanick.

Revision 2:
- Fixed setting switch cases prior to PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT 
incorrectly.
- Fixed memory leak.


Best regards,
Siavash Eliasi.

Siavash Eliasi (17):
   softpipe: Modified allocation routine to use alignment of 64 instead
     of 16.
   softpipe: Modified softpipe to return 64 in case of
     PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT.
   llvmpipe: Modified allocation routines to use alignment of 64 instead
     of 16.
   llvmpipe: Modified llvmpipe to return 64 in case of
     PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT.
   i915: Modified i915_buffer_create to use memory allocation alignment
     of 64 instead of 16.
   i915: Modified i915g to return 64 in case of
     PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT.
   svga: Modified svga to return 64 in case of
     PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT.
   ilo: Modified ilo to return 4096 in case of
     PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT.
   mesa: Modified Mesa state tracker to unconditionally enable
     ARB_map_buffer_alignment.
   mesa: Modified _mesa_init_constants to set
     ctx->Const.MinMapBufferAlignment to 64.
   mesa: Modified _mesa_buffer_data to use _mesa_align_malloc.
   radeon: Modified radeonBufferData to pass
     ctx->Const.MinMapBufferAlignment as the alignment value to
     radeon_bo_open.
   nouveau: Modified nouveau_bufferobj_data to pass
     ctx->Const.MinMapBufferAlignment as the alignment value to
     nouveau_bo_new.
   i915: Modified i915 intel_bufferobj_data to use _mesa_align_malloc
     instead of malloc.
   i965: Modified brw_initialize_context_constants to set
     ctx->Const.MinMapBufferAlignment to 4096.
   mesa: Modified extensions table to use o(dummy_true) instead of
     o(ARB_map_buffer_alignment).
   mesa: Deleted gl_extensions::ARB_map_buffer_alignment and all of its
     use cases.

  src/gallium/drivers/i915/i915_resource_buffer.c     | 2 +-
  src/gallium/drivers/i915/i915_screen.c              | 3 ++-
  src/gallium/drivers/ilo/ilo_screen.c                | 2 +-
  src/gallium/drivers/llvmpipe/lp_screen.c            | 3 ++-
  src/gallium/drivers/llvmpipe/lp_texture.c           | 4 ++--
  src/gallium/drivers/softpipe/sp_screen.c            | 3 ++-
  src/gallium/drivers/softpipe/sp_texture.c           | 2 +-
  src/gallium/drivers/svga/svga_screen.c              | 3 ++-
  src/mesa/drivers/dri/i915/intel_buffer_objects.c    | 4 ++--
  src/mesa/drivers/dri/i965/brw_context.c             | 2 ++
  src/mesa/drivers/dri/nouveau/nouveau_bufferobj.c    | 3 ++-
  src/mesa/drivers/dri/radeon/radeon_buffer_objects.c | 2 +-
  src/mesa/main/bufferobj.c                           | 7 +++++--
  src/mesa/main/context.c                             | 1 +
  src/mesa/main/extensions.c                          | 2 +-
  src/mesa/main/get.c                                 | 1 -
  src/mesa/main/get_hash_params.py                    | 2 +-
  src/mesa/main/mtypes.h                              | 1 -
  src/mesa/state_tracker/st_extensions.c              | 4 +---
  19 files changed, 29 insertions(+), 22 deletions(-)


_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to