I made _mesa_PushAttrib a bit nicer with helper function as Topi suggested, it made the entire _mesa_PushAttrib look more clean.
_mesa_PushClientAttrib I did not go touching anymore, helper for _mesa_PushAttrib could not be used here and save_attrib_data would need a duplicate function if it was to start handling allocation of the incoming attribute parameter allocation. Added the missing space for patch to DRI2WireToEvent (I blame autoformatter for losing this originally :) ) and new to the Klocwork patch list is patch to dri2CreateDrawable Juha-Pekka Heikkila (5): Mesa: Change save_attrib_data() to return boolean mesa: Verify memory allocations success in _mesa_PushClientAttrib mesa: Verify memory allocations success in _mesa_PushAttrib glx: Add missing null check in DRI2WireToEvent glx: Add missing null check in dri2CreateDrawable src/glx/dri2.c | 2 + src/glx/dri2_glx.c | 6 + src/mesa/main/attrib.c | 301 +++++++++++++++++++++++++++++++++---------------- 3 files changed, 214 insertions(+), 95 deletions(-) -- 1.8.1.2 _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
