I checked the issues Brian mentioned on the Push*Attrib and related patches. I agree this is just null checking patch but following Topi's suggestion PushAttrib becomes much more clean looking thus the bit bigger change than just checking after nulls here and there is worthy imho. Hope I did not miss any of Brian's comments.
Extra null checking in dri2_bind_tex_image is new to my set. /Juha-Pekka Juha-Pekka Heikkila (5): Mesa: Change save_attrib_data() to return boolean mesa: Verify memory allocations success in _mesa_PushClientAttrib mesa: Verify memory allocations success in _mesa_PushAttrib glx: Add missing null check in dri2CreateDrawable glx: add missing null check in dri2_bind_tex_image src/glx/dri2_glx.c | 9 +- src/mesa/main/attrib.c | 310 ++++++++++++++++++++++++++++++++++--------------- 2 files changed, 221 insertions(+), 98 deletions(-) -- 1.8.1.2 _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev