On Sat, Jan 04, 2014 at 10:25:52PM +0100, Bruno Jimenez wrote: > On Sat, 2014-01-04 at 13:08 -0800, Tom Stellard wrote: > > [snip] > > > > > > > So, you were wright, I changed the behaviour for > > > need == 0. But just checking for need < 0 should > > > address it. > > > > > > > Thanks for the explanation. I understand what is happening now. > > This change should be OK, but I'd like to do at least one piglit run > > just to verify. Do you have the HW to test this? > > Hi, > > I think I have the hardware, as my card uses the r600 driver (it's an > AMD Mobility Radeon HD5470) But I will need some help > to use piglit... some time ago I tried installing it but > failed completely >
You don't need to install use it, in fact I don't know of anyone who installs it. Here is a quick guide to using piglit: 1. Checkout the source from git. 2. Run ccmake . in the root directory 3. Make sure you enable the OpenCL tests 4. Build the tests: make -j5 5. Do a test run with: ./piglit-run.py tests/all_cl.tests results/cl-tests Do one test run with and without the patches and then use ./piglit-summary-html.py to compare the results. Make sure you have built r600g with OpenCL support. Directions for doing this are here: http://dri.freedesktop.org/wiki/GalliumCompute/ -Tom > Thanks in advance! > Bruno > > > > -Tom > > > > > If this is OK, I'll prepare a version 2 of the patches > > > later for submission. > > > > [snip] > > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev