On 01/10/2014 07:34 PM, Paul Berry wrote: > Prior to this patch, if we ran out of aperture space during > brw_try_draw_prims(), we would rewind the batch buffer pointer > (potentially throwing some state that may have been emitted by > brw_upload_state()), flush the batch, and then try again. However, we > wouldn't reset the dirty bits to the state they had before the call to > brw_upload_state(). As a result, when we tried again, there was a > danger that we wouldn't re-emit all the necessary state. (Note: prior > to the introduction of hardware contexts, this wasn't a problem > because flushing the batch forced all state to be re-emitted). > > This patch fixes the problem by leaving the dirty bits set at the end > of brw_upload_state(); we only clear them after we have determined > that we don't need to rewind the batch buffer. > > Cc: 10.0 9.2 <mesa-sta...@lists.freedesktop.org>
Thanks a ton for fixing this, Paul. Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
