Re: [Mesa-dev] [PATCH 5/8] glsl: Statically cast parameter exec_node to ir_variable.

[Ian Romanick]

On 01/11/2014 02:37 AM, Kenneth Graunke wrote:
> Formal function parameters are always ir_variable objects, not an
> arbitrary ir_instruction.  So there's no need to dynamically cast here.

...especially since we never bother to check that as_variable doesn't
return NULL.

> Signed-off-by: Kenneth Graunke <kenn...@whitecape.org>
> ---
>  src/glsl/builtin_functions.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp
> index 5b8463a..662ff4c 100644
> --- a/src/glsl/builtin_functions.cpp
> +++ b/src/glsl/builtin_functions.cpp
> @@ -2399,7 +2399,7 @@ builtin_builder::call(ir_function *f, ir_variable *ret, 
> exec_list params)
>     exec_list actual_params;
>  
>     foreach_list(node, &params) {
> -      ir_variable *var = ((ir_instruction *) node)->as_variable();
> +      ir_variable *var = (ir_variable *) node;
>        actual_params.push_tail(var_ref(var));
>     }
>  
> 

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev