On 28 January 2014 13:15, Carl Worth <cwo...@cworth.org> wrote: > Paul Berry <stereotype...@gmail.com> writes: > > Previous to this patch, the _mesa_{Begin,Resume}TransformFeedback > > functions were using ctx->Shader.CurrentProgram[MESA_SHADER_VERTEX] > > I see that this commit was nominated for the stable branch when it was > committed. > > However, it appears to depend at least on commit b22146dc714 which is on >
I think you mean 3b22146dc714 (mesa: Replace ctx->Shader.Current{Vertex,Fragment,Geometry}Program with an array.). > master, but is not on the 10.0 branch. So this patch cannot be applied > as-is to 10.0. > > My current inclination is to simply drop this patch from the list of > candidates for 10.0. If you think differently, please recommend an > alternate plan. > > -Carl > (Also from IRC: <cworth> stereotype441: In my recent mail, I should have included 43e77215b13 as well. (It's another patch I plan to drop from stable unless you guide me differently.)) In principle we could make versions of these patches that don't depend on commit 3b22146dc714, but I don't think it's worth it--the bugs I've fixed in these patches are unlikely to arise until ARB_separate_shader_objects is supported. So yeah, I'm ok with dropping these two patches from the list of candidates for 10.0. I believe it was Ken who initially suggested marking these patches as candidates for stable. Cc'ing him in case he wants to express a dissenting opinion.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev