On Tue, Jan 28, 2014 at 2:13 PM, Ian Romanick <i...@freedesktop.org> wrote:
> On 01/28/2014 02:51 PM, Mark Mueller wrote: > > This patch could cause the i965 driver to not load if Mesa was built on > > a system without libudev devel present. For example on Fedora one should > > install systemd-devel before configuring and building Mesa drivers > > subsequent to this change. > > I don't think so. loader_get_driver_for_fd should return NULL in that > case, and the loader will fallback to the old behavior. > Except it doesn't; it goes and grabs the kernel module name. For example on an i965 it will try to open the i915 driver, because that's the name of the kernel module. The erroneous assumption in this patch is that dri2 implies libudev is present (this isn't checked by ./configure). Although that is true with dri3, it's not the case with dri2. So in that respect the patch is incorrect. Stéphane > > On Sun, Jan 26, 2014 at 4:02 PM, Keith Packard <kei...@keithp.com > > <mailto:kei...@keithp.com>> wrote: > > > > Eric Anholt <e...@anholt.net <mailto:e...@anholt.net>> writes: > > > > > This allows Mesa to choose to rename driver .sos (or split > drivers), > > > without needing a flag day with the corresponding 2D driver. > > > > Reviewed-by: Keith Packard <kei...@keithp.com > > <mailto:kei...@keithp.com>> > > > > -- > > keith.pack...@intel.com <mailto:keith.pack...@intel.com> > > > > _______________________________________________ > > mesa-dev mailing list > > mesa-dev@lists.freedesktop.org <mailto: > mesa-dev@lists.freedesktop.org> > > http://lists.freedesktop.org/mailman/listinfo/mesa-dev > > > > > > > > > > _______________________________________________ > > mesa-dev mailing list > > mesa-dev@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/mesa-dev > > > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev >
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
