On Fri, Mar 28, 2014 at 6:28 AM, Juha-Pekka Heikkila <juhapekka.heikk...@gmail.com> wrote: > v3: > I took out accumulator flag from backend_instruction::has_side_effects() > as Matt suggested and rebased my patches on top of master where had shown up > Matt's patches which were overlapping a bit on dead code elimination. > This set does not do anything for the MACH anomaly on vec4_visitor::visit > and fs_visitor:::visit, I will reverify it and do something about it later > if needed. I tried these on Ironlake maching and did not see any regression > on Piglit quick set.
I sent comments on patch 1, but 2-5 are Reviewed-by: Matt Turner <matts...@gmail.com> No need to resend 2-5. When patch 1 is updated and reviewed I'll push them all. A good follow-on patch would be to add some assertions to the generator code that ensure we're not violating any of the accumulator restrictions. See the "Accumulator Restrictions" section of IVB's PRM Vol 4 Part 3. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
