On 04/08/2014 01:25 PM, Chris Forbes wrote: > Ian, > > Would we put that format in a view class by itself?
I think the BGRA8 could go in VIEW_CLASS_32_BITS. If you create an RGBA8 view of a BGRA8 texture you'll get swizzled reads. Given that you can create a RGB9_E5 view of a RGB10_A2UI texture, I think this is fine. > -- Chris > > On Wed, Apr 9, 2014 at 7:49 AM, Ian Romanick <[email protected]> wrote: >> On 04/08/2014 02:13 AM, Kenneth Graunke wrote: >>> On 04/02/2014 01:04 AM, Chris Forbes wrote: >>>> This series adds ARB_texture_view support for i965 Gen7/7.5. >>>> >>>> Significant changes from V2: >>>> >>>> - All the assorted post-V2 format fixups are moved to the start of the >>>> series. >>>> This gives us consistent memory layout for all the formats between which >>>> we >>>> have to support casting. >>>> - Texture validation changes are simplified (Eric) >>>> - CopyTexSubImage respects view parameters. >>> >>> Series is: >>> Reviewed-by: Kenneth Graunke <[email protected]> >>> >>> I do think it would be worth trying various benchmarks and games against >>> the series, to see if the RGBA vs. BGRA swizzling issue makes much of a >>> difference. It will probably change some things, but I don't have a >>> good sense of how. >> >> I believe the losing BGRA is going to hurt web browsers... Eric also >> indicated that it would hurt Glamor. I think we should add an extension >> that enables BGRA for TexStorage. On ES, EXT_texture_storage + >> APPLE_texture_format_BGRA8888 does this by adding GL_BGRA8_EXT as an >> internal format for *only* TexStorage. >> >>> I'll also need to port this to Gen8... >>> >>> Nice work, Chris! Thanks for doing this. >>> >>> _______________________________________________ >>> mesa-dev mailing list >>> [email protected] >>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
