On Wed, May 7, 2014 at 4:18 AM, Kevin Rogovin <kevin.rogo...@intel.com> wrote:
> Add support for GLES2 extensions for floating point and half
> floating point textures (GL_OES_texture_float, GL_OES_texture_half_float,
> GL_OES_texture_float_linear and GL_OES_texture_half_float_linear).
The patch basically looks good. We're lacking piglit tests for these
extensions, and I think we'll want some before we turn these
extensions on.
> ---
> src/mesa/main/extensions.c | 12 +++++++++-
> src/mesa/main/glformats.c | 25 ++++++++++++++++++++
> src/mesa/main/pack.c | 17 +++++++++++++
> src/mesa/main/teximage.c | 59
> ++++++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 112 insertions(+), 1 deletion(-)
>
> diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c
> index c2ff7e3..e39f65e 100644
> --- a/src/mesa/main/extensions.c
> +++ b/src/mesa/main/extensions.c
> @@ -301,7 +301,17 @@ static const struct extension extension_table[] = {
> { "GL_OES_texture_mirrored_repeat", o(dummy_true),
> ES1, 2005 },
> { "GL_OES_texture_npot",
> o(ARB_texture_non_power_of_two), ES1 | ES2, 2005 },
> { "GL_OES_vertex_array_object", o(dummy_true),
> ES1 | ES2, 2010 },
> -
> + /*
> + * TODO:
> + * - rather than have an all or nothing approach for floating point
> textures,
> + * allow for driver to specify what parts of floating point texture
> functionality
> + * is supported: float/half-float and filtering for each.
> + */
> + { "GL_OES_texture_float", o(ARB_texture_float),
> ES2, 2005 },
> + { "GL_OES_texture_half_float", o(ARB_texture_float),
> ES2, 2005 },
> + { "GL_OES_texture_float_linear", o(ARB_texture_float),
> ES2, 2005 },
> + { "GL_OES_texture_half_float_linear", o(ARB_texture_float),
> ES2, 2005 },
> +
These extensions still aren't sorted into the GL_OES_* list. I'll just
do that when I commit it. I don't see a lot of use in the TODO
comment, so I might remove it as well...?
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
