On May 20, 2014, at 05:57, Jon TURNEY <jon.tur...@dronecode.org.uk> wrote:
> On 20/05/2014 09:57, Jeremy Huddleston Sequoia wrote: >> Reviewed-by: Jeremy Huddleston Sequoia with one minor change (see below): > > Thanks very much for taking the time to review these. No, thank you for taking the time to do them. >> On May 13, 2014, at 05:15, Jon TURNEY wrote: >>> >>> +SUBDIRS+=. tests >>> + >>> include $(top_srcdir)/install-lib-links.mk >> >> Because SUBDIRS is set conditionally, you should add: >> >> DIST_SUBDIRS = tests apple >> >> to handle what I assume is an eventual goal of supporting 'make dist' > > I don't think that is needed in this case, as automake should be smart enough > to work it out correctly. My experience is that automake isn't quite that smart (cf: DIST_SUBDIRS usage through xserver). I'd prefer to be on the safe side, but either way is fine with me (we can always just add it later if automake misbehaves). _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
