On Tue, Jun 10, 2014 at 6:00 PM, Ian Romanick <i...@freedesktop.org> wrote: > On 06/09/2014 07:48 AM, Robert Bragg wrote: >> This makes sure to use a no-op swizzle while iteratively rendering each >> level of a mipmap otherwise we may loose components and effectively >> apply the swizzle twice by the time these levels are sampled. > > Right... the swizzle state shouldn't affect mipmap generation at all. > One minor nit below, but otherwise > > Reviewed-by: Ian Romanick <ian.d.roman...@intel.com> > > I second Chris's request for a piglit test. It should be pretty easy to > clone one of the existing tests/fbo/fbo-generatemipmap-*.c tests and > modify it to test this case.
Thanks Chris and Ian for the review; I've landed the patch and sent a test case to the piglit mailinglist. -- Robert _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
