Anuj Phogat <anuj.pho...@gmail.com> writes: >> #if 0 >> #else garbage >> #endif >> >> The Khronos test contains two tokens after #else. I'm not sure if that >> is the difference or not. > Khronos is testing many different cases. Failing case tests: > > #if 1 > #else garbage > #endif
It is the "#if 1" that causes the existing code to catch the garbage after #else. So yes, the existing test case does need to be expanded. In the meantime, the proposed fix (to the lexer) is not correct as it will cause an error in the following case which should be accepted: #if 1 #else /* comments are whitespace, not garbage */ #endif I'll poke around at the existing code to see why the garbage after #else is caught with #if 0, but not with #if 1. -Carl -- carl.d.wo...@intel.com
pgpcb4XjmIxLV.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev