On Thu, Aug 14, 2014 at 12:24 AM, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Wed, 13 Aug 2014 19:46:40 +0300 > "Pohjolainen, Topi" <topi.pohjolai...@intel.com> wrote: > >> On Fri, Aug 08, 2014 at 05:28:59PM +0300, Pekka Paalanen wrote: >> > From: Pekka Paalanen <pekka.paala...@collabora.co.uk> >> > >> > The EGL_EXT_image_dma_buf_import specification was revised (according to >> > its revision history) on Dec 5th, 2013, for EGL to not take ownership of >> > the file descriptors. >> > >> > Do not close the file descriptors passed in to eglCreateImageKHR with >> > EGL_LINUX_DMA_BUF_EXT target. >> > >> > It is assumed, that the drivers, which ultimately process the file >> > descriptors, do not close or modify them in any way either. This avoids >> > the need to dup(), as it seems we would only need to just close the >> > dup'd file descriptors right after. >> > >> > Signed-off-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> >> >> I wrote the current logic based on the older version, and at least to me this >> is the right thing to do. Thanks for fixing it as well as taking care of the >> piglit test. >> >> Reviewed-by: Topi Pohjolainen <topi.pohjolai...@intel.com> >> >> I would be happier though if someone else gave his/her approval as well. > > Thank you, I have added your R-b, and will wait some more. I think I > want the piglit patch landed first before I try to push this, anyway. > > Thanks for the piglit review too, I sent a new version with your R-b > and the comment fix.
The plan is to make the 10.3 branch tomorrow, so don't wait too long. :) _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev