Hi,
On Thu, Aug 28, 2014 at 6:09 PM, Giovanni Campagna < scampa.giova...@gmail.com> wrote: > On Thu, Aug 28, 2014 at 4:01 PM, Emil Velikov <emil.l.veli...@gmail.com> > wrote: > > On 22/08/14 17:41, Andreas Pokorny wrote: > >> Allows using prime fds as display target and from display target. > >> Test for PRIME capability after initializing kms_swrast screen. > >> > > Hi Andreas, > > > > I'm hoping that Giovanni will take a look. After all kms-dri is his > creation. > > I'm not sure I'm the right person to look at this code. After all I'm > not a mesa developer. > > From a cursory review, the patches look good to me, but what I'm not > seeing are the necessary EGL changes to make use of prime fds with > kms-swrast, eg. EGL_WL_bind_wayland_display is still not exposed, even > though it could be implemented using prime fds. > I have no clue on the current state of what wayland requires. There seem to be a lot of options now. I assumed the patch is one of the necessary pieces. > Another thing is, you briefly mentioned the generic GEM ioctls. If > drivers really can use the generic GEM_FLINK/GEM_OPEN ioctl to give a > name to dumb buffers, then indeed the kms-swrast driver is capable of > buffer sharing (I always assumed that a somehow real GEM was > necessary, and that the simple one in qxl/cirrus/simpledrm was not > enough). I'd like to see that implemented first, which would allow to > remove a good amount of complexity and special casing in gallium and > egl (and would allow using kms-swrast for faster sw wayland too). > I was about to do that, then recent regressions in kvm utils and some low hanging fruits in i915 distracted me. .. so real soon now.. regards Andreas
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev