On 12/13/2014 02:09 AM, Timothy Arceri wrote: > On Fri, 2014-12-12 at 07:01 -0600, kallisti5 wrote: >> On 2014-12-12 05:46, Timothy Arceri wrote: >>> Signed-off-by: Timothy Arceri <t_arc...@yahoo.com.au> >>> --- >>> src/mesa/main/compiler.h | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h >>> index 34671dc..cdc843d 100644 >>> --- a/src/mesa/main/compiler.h >>> +++ b/src/mesa/main/compiler.h >>> @@ -122,7 +122,7 @@ extern "C" { >>> * inline a static function that we later use in an alias. - ajax >>> */ >>> #ifndef PUBLIC >>> -# if (defined(__GNUC__) && __GNUC__ >= 4) || (defined(__SUNPRO_C) && >>> (__SUNPRO_C >= 0x590)) >>> +# if defined(__GNUC__) || (defined(__SUNPRO_C) && (__SUNPRO_C >= >>> 0x590)) >>> # define PUBLIC __attribute__((visibility("default"))) >>> # define USED __attribute__((used)) >>> # else >> >> Why not also drop the SUNPRO_C version check? >> >> # if defined(__GNUC__) || defined(__SUNPRO_C) >> >> I downloaded SunStudio 12 (circa 2007) and __SUNPRO_C is set to 0x590. >> If we drop support for GCC 4.1 (2007), might as well drop older sun >> compilers. > > The series is dropping support for GCC 4.0. 4.1 is shipped with Redhat > Enterprise Linux 5 which is still in support so I've set that as the > minimum version. > > The dropping old versions of SunStudio should be done in a separate > patch. I don't really know much about SunStudio but I think you would > also need to add something to the config to enforce a minimum version if > you were to start removing version checks like this.
It seems like a good thing to do, none the less. You should CC Alan Coopersmith on the patches. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev