On Sunday, January 18, 2015 01:04:03 AM Francisco Jerez wrote:
> And remove the mocs argument of the emit_buffer_surface_state vtbl hook.  Its
> semantics vary greatly from one generation to another, so it kind of
> encourages the caller to pass 0 which is the only valid setting across
> generations.  After this commit the hardware-specific code decides what the
> best cacheability settings are for buffer surfaces, just like we do for
> textures.
> 
> This together with some additional changes coming is expected to improve
> performance of pull constants, buffer textures, atomic counters and image
> objects on Gen7 and up.

Thanks!  I had a version of this lying around, but never measured any gain
from it, so I never bothered to send it.  I definitely like removing the
parameter, and we probably should set it - we do everywhere else...

This patch is:
Reviewed-by: Kenneth Graunke <kenn...@whitecape.org>

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to