> -----Original Message----- > From: Kenneth Graunke [mailto:kenn...@whitecape.org] > Sent: Thursday, January 22, 2015 8:02 AM > To: mesa-dev@lists.freedesktop.org > Cc: Predut, Marius; mesa-sta...@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH v1] Remove UINT_AS_FLT, INT_AS_FLT, > FLOAT_AS_FLT macros.No functional changes, only bug fixed. > > On Thursday, January 22, 2015 12:12:18 AM marius.pre...@intel.com wrote: > > From: Marius Predut <marius.pre...@intel.com> > > > > On 32-bit, for floating point operations is used x86 FPU registers > > instead SSE, reason for when reinterprets an integer as a float > > result is unexpected (modify floats when they are written to memory). > > > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82668 > > > > Signed-off-by: Marius Predut <marius.pre...@intel.com> > > --- > > src/mesa/main/context.c | 3 ++- > > src/mesa/main/macros.h | 32 ++++++++++++++++---------------- > > src/mesa/vbo/vbo_attrib_tmp.h | 20 ++++++++++++++++---- > > src/mesa/vbo/vbo_exec.h | 3 ++- > > src/mesa/vbo/vbo_exec_api.c | 25 ++++++++++++------------- > > src/mesa/vbo/vbo_exec_eval.c | 22 +++++++++++++++++----- > > src/mesa/vbo/vbo_save_api.c | 10 +++++----- > > 7 files changed, 70 insertions(+), 45 deletions(-) > > Your commit title says "No functional changes, only bug fixed." This is > contradictory - a bug fix is a change in behavior, or a "functional change." > > "No functional changes" is a phrase used for patches which alter whitespace, > comments, change style, or move code around while not actually changing the > result of the code. > > Removing the macros is also not really the point of the patch - it's fixing an > x86 FPU bug. I would make the commit title something to that effect. Sure, can you do that. thanks
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
